search

sdss / mangadap

The MaNGA Data Analysis Pipeline
BSD 3-Clause "New" or "Revised" License
16 stars 8 forks source link

Merge `develop` branch into `muse_dev` #99

Closed kbwestfall closed 2 years ago

kbwestfall commented 2 years ago

Hi @khrrubin , @erickaguirre96. This merges the current develop branch into muse_dev. (I made this muse_dev_test branch by doing that merge myself first and handling the conflicts.) This picks up a ton of edits, starting from MPL-11 and including more recent updates to the develop branch (see the change log in CHANGES.md starting with changes since version 3.0.1). You can ignore many of the edits, but you should pay attention to the specific edits you made for MUSE. There are a few that I reverted because of recent changes that I made, including enabling the code to handle when there are no unmasked spaxels in the cube and fixing some of the issues you found in a slightly different way.

This is the first of at least two merges that I want to do. I'm currently working in a branch (io) that is going to make even more dramatic changes. It reworks much of the I/O so that, e.g., things don't require a plate-ifu naming convention. I have the main MaNGA DAP script and all the QA plots working for KCWI. Anyway, I wanted to start with this merge, hoping that it will make the next merge easier. It would be great if you could test this branch to make sure I haven't broken anything in the merge.

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (muse_dev@8b58a6c). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             muse_dev      #99   +/-   ##
===========================================
  Coverage            ?   35.04%           
===========================================
  Files               ?       84           
  Lines               ?    18997           
  Branches            ?        0           
===========================================
  Hits                ?     6657           
  Misses              ?    12340           
  Partials            ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b58a6c...0b30931. Read the comment docs.