Error with Investigating Gas and Stellar Kinematics Exercise

sdss / marvin

Data access and visualization for MaNGA. http://sdss-marvin.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

55 stars 32 forks source link

Error with Investigating Gas and Stellar Kinematics Exercise #767

Closed TheRealEKL closed 2 years ago

TheRealEKL commented 2 years ago

Hello, when I download the Jupyter Notebook for the Marvin exercise "Investigating Gas and Stellar Kinematics", I receive this error:

I am using this exercise as a reference to learn how to multiply / divide maps to acquire a new map. Specifically, I am trying to learn how to do this in order to complete the "Computing Star-Formation Rates and SFR Densities using Marvin" exercise which has no solution. Thank you!

astromariarosa commented 2 years ago

I'm unsure if there are nuances I'm missing regarding the intention of those lines, but swapping the first two lines with diff = havel - stvel and then explicitly updating the ivar, mask, etc. as originally written works for me.

For the Marvin team: if this is a valid approach, could this be updated in the Kinematics exercise?

havok2063 commented 2 years ago

@TheRealEKL Sorry the delay in seeing this. This has been an outstanding issue with this notebook for a while but haven't had the time to look into it. @astromariarosa If that solution works, and makes a working notebook, then yeah I think it's reasonable to update the notebook. Would you mind submitting a PR with those changes?

havok2063 commented 2 years ago

This is fixed in the latest 2.7.3 release of marvin. The docs should now be updated.