sdsweb / note

Note is a simple and easy to use widget for editing bits of text, live, in your WordPress front-end Customizer.
GNU General Public License v2.0
19 stars 5 forks source link

WP_Customize_Manager::remove_panel was called incorrectly #15

Closed lmartins closed 8 years ago

lmartins commented 8 years ago

Hi,

I've started to get a lot of PHP notices related to Note which event though they are only notices, they seem to be preventing the user from navigating the site within the customizer.

Full stack trace:

 Marker - 02 May 2016 11:26:00
[02-May-2016 10:26:50 UTC] PHP Notice:  WP_Customize_Manager::remove_panel was called <strong>incorrectly</strong>. Removing widgets manually will cause PHP warnings. Use the <a href="https://developer.wordpress.org/reference/hooks/customize_loaded_components/"><code>customize_loaded_components</code></a> filter instead. Please see <a href="https://codex.wordpress.org/Debugging_in_WordPress">Debugging in WordPress</a> for more information. (This message was added in version 4.5.) in /Users/luismartins/Sites/webipack.dev/wp-includes/functions.php on line 3897
[02-May-2016 10:26:50 UTC] PHP Stack trace:
[02-May-2016 10:26:50 UTC] PHP   1. {main}() /Users/luismartins/Sites/webipack.dev/wp-admin/customize.php:0
[02-May-2016 10:26:50 UTC] PHP   2. require_once() /Users/luismartins/Sites/webipack.dev/wp-admin/customize.php:13
[02-May-2016 10:26:50 UTC] PHP   3. require_once() /Users/luismartins/Sites/webipack.dev/wp-admin/admin.php:31
[02-May-2016 10:26:50 UTC] PHP   4. require_once() /Users/luismartins/Sites/webipack.dev/wp-load.php:37
[02-May-2016 10:26:50 UTC] PHP   5. require_once() /Users/luismartins/Sites/webipack.dev/wp-config.php:99
[02-May-2016 10:26:50 UTC] PHP   6. do_action() /Users/luismartins/Sites/webipack.dev/wp-settings.php:393
[02-May-2016 10:26:50 UTC] PHP   7. Note_Customizer->init() /Users/luismartins/Sites/webipack.dev/wp-includes/plugin.php:525
[02-May-2016 10:26:50 UTC] PHP   8. Note_Sidebars::get_customizer_sidebar_args() /Users/luismartins/Sites/webipack.dev/wp-content/plugins/note/includes/class-note-customizer.php:147
[02-May-2016 10:26:50 UTC] PHP   9. WP_Customize_Manager->remove_panel() /Users/luismartins/Sites/webipack.dev/wp-content/plugins/note/includes/class-note-sidebars.php:703
[02-May-2016 10:26:50 UTC] PHP  10. _doing_it_wrong() /Users/luismartins/Sites/webipack.dev/wp-includes/class-wp-customize-manager.php:1221
[02-May-2016 10:26:50 UTC] PHP  11. trigger_error() /Users/luismartins/Sites/webipack.dev/wp-includes/functions.php:3897
[02-May-2016 10:26:50 UTC] PHP Notice:  Array to string conversion in /Users/luismartins/Sites/webipack.dev/wp-includes/formatting.php on line 1025
[02-May-2016 10:26:50 UTC] PHP Stack trace:
[02-May-2016 10:26:51 UTC] PHP   1. {main}() /Users/luismartins/Sites/webipack.dev/wp-admin/customize.php:0
[02-May-2016 10:26:51 UTC] PHP   2. do_action() /Users/luismartins/Sites/webipack.dev/wp-admin/customize.php:185
[02-May-2016 10:26:51 UTC] PHP   3. WP_Customize_Manager->customize_pane_settings() /Users/luismartins/Sites/webipack.dev/wp-includes/plugin.php:525
[02-May-2016 10:26:51 UTC] PHP   4. WP_Customize_Control->json() /Users/luismartins/Sites/webipack.dev/wp-includes/class-wp-customize-manager.php:1783
[02-May-2016 10:26:51 UTC] PHP   5. WP_Customize_Control->to_json() /Users/luismartins/Sites/webipack.dev/wp-includes/class-wp-customize-control.php:309
[02-May-2016 10:26:51 UTC] PHP   6. WP_Customize_Control->get_content() /Users/luismartins/Sites/webipack.dev/wp-includes/class-wp-customize-control.php:295
[02-May-2016 10:26:51 UTC] PHP   7. WP_Customize_Control->maybe_render() /Users/luismartins/Sites/webipack.dev/wp-includes/class-wp-customize-control.php:353
[02-May-2016 10:26:51 UTC] PHP   8. WP_Customize_Control->render() /Users/luismartins/Sites/webipack.dev/wp-includes/class-wp-customize-control.php:388
[02-May-2016 10:26:51 UTC] PHP   9. WP_Customize_Control->render_content() /Users/luismartins/Sites/webipack.dev/wp-includes/class-wp-customize-control.php:401
[02-May-2016 10:26:51 UTC] PHP  10. esc_attr() /Users/luismartins/Sites/webipack.dev/wp-includes/class-wp-customize-control.php:562
[02-May-2016 10:26:51 UTC] PHP  11. wp_check_invalid_utf8() /Users/luismartins/Sites/webipack.dev/wp-includes/formatting.php:3557
[02-May-2016 10:26:52 UTC] PHP Notice:  WP_Customize_Manager::remove_panel was called <strong>incorrectly</strong>. Removing widgets manually will cause PHP warnings. Use the <a href="https://developer.wordpress.org/reference/hooks/customize_loaded_components/"><code>customize_loaded_components</code></a> filter instead. Please see <a href="https://codex.wordpress.org/Debugging_in_WordPress">Debugging in WordPress</a> for more information. (This message was added in version 4.5.) in /Users/luismartins/Sites/webipack.dev/wp-includes/functions.php on line 3897
[02-May-2016 10:26:52 UTC] PHP Stack trace:
[02-May-2016 10:26:52 UTC] PHP   1. {main}() /Users/luismartins/Sites/webipack.dev/index.php:0
[02-May-2016 10:26:52 UTC] PHP   2. require() /Users/luismartins/Sites/webipack.dev/index.php:17
[02-May-2016 10:26:52 UTC] PHP   3. require_once() /Users/luismartins/Sites/webipack.dev/wp-blog-header.php:13
[02-May-2016 10:26:52 UTC] PHP   4. require_once() /Users/luismartins/Sites/webipack.dev/wp-load.php:37
[02-May-2016 10:26:52 UTC] PHP   5. require_once() /Users/luismartins/Sites/webipack.dev/wp-config.php:99
[02-May-2016 10:26:52 UTC] PHP   6. do_action() /Users/luismartins/Sites/webipack.dev/wp-settings.php:393
scottsousa commented 8 years ago

Hi @lmartins,

We came across this bug/notice during testing last week. We're looking to have a fix released soon (hopefully today).

Thank you for reporting it to us and I apologize for the inconvenience.

scottsousa commented 8 years ago

Hi @lmartins

We just pushed version 1.4.1 to WordPress.org. The update should start to come through to your sites within a few hours.

https://github.com/sdsweb/note/commit/06ee199309894c1c41a535db4c165cfdfe8eaa2d

Thanks again.

lmartins commented 8 years ago

Thank you also for the help and feedback @scottsousa . Best.