Add support for HEIC format

sdsykes / fastimage

FastImage finds the size or type of an image given its uri by fetching as little as needed

http://github.com/sdsykes/fastimage/tree/master

MIT License

1.37k stars 115 forks source link

Add support for HEIC format #125

Closed stefanoverna closed 3 years ago

stefanoverna commented 3 years ago

Hi! Is HEIC format detection interesting to you? :wink:

sdsykes commented 3 years ago

Awesome. I'll review this as soon as I can

sdsykes commented 3 years ago

Just a thought, not related to this PR directly, but as it adds more than 150 lines of code - do you think it's time I split fastimage.rb into separate files?

stefanoverna commented 3 years ago

Of course it would make sense!

sdsykes commented 3 years ago

This looks good, I think it's pretty much good to merge. After merge it'll be time to look at dividing into smaller files :)

stefanoverna commented 3 years ago

Done @sdsykes, thanks for the review!