sdsykes
commented
11 years ago It's surprising that you get unknown columns given that the callsite hash calculation uses the part of the select query that contains the table names. Do you have logs of what type of queries cause these problems?
I'm not sure what the logic you would wish for the first time code. If you don't load any columns, then it is very likely you will always need to reload. In this case scrooge reloads all columns to avoid making a query for every new columns that is required. Particularly the first time through this is usually desirable, but seeing as we know we have to reload anyway, you may as well load all columns at the start.
If you are suggesting we determine what to load initially partly by column type, that is certainly an enhancement that could be considered. Patch welcome!
Vittly
Hello! We use scrooge (1.0.12) in large-production-rails-application and sometimes (twice a week)) we got MySQL "unknown columns" exception becouse of your hash-based algorithm of callsites keys calculation. May be you need to improve it. Another case is about logic. Slimscrooge 1st time loads full objects from database and then with monitored_hash tries to calculate what columns were needed. 2nd time it loads only these columns. But may be you should not load 1st time large columns (blobs, texts) and reload them if needed. It would be better logic in cases of large amount of result rows.