codecov[bot]
commented
2 years ago Codecov Report
Merging #119 (2a4de1a) into master (05f4fef) will increase coverage by
1.62%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
+ Coverage 48.05% 49.68% +1.62%
==========================================
Files 11 11
Lines 643 636 -7
==========================================
+ Hits 309 316 +7
+ Misses 334 320 -14 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/util.rs | 78.89% <0.00%> (-8.86%) |
:arrow_down: |
| src/config.rs | 83.33% <0.00%> (-1.78%) |
:arrow_down: |
| src/message.rs | 21.25% <0.00%> (-0.62%) |
:arrow_down: |
| src/log.rs | 100.00% <0.00%> (ø) |
|
| src/repo.rs | 0.00% <0.00%> (ø) |
|
| src/extensions.rs | 81.25% <0.00%> (+5.88%) |
:arrow_up: |
| src/arguments.rs | 86.86% <0.00%> (+10.94%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 05f4fef...2a4de1a. Read the comment docs.
This PR has
43quantified lines of changes. In general, a change size of upto200lines is ideal for the best PR experience!Quantification details
``` Label : Extra Small Size : +27 -16 Percentile : 17.2% Total files changed: 1 Change summary by file extension: .yml : +27 -16 ``` > Change counts above are quantified counts, based on the [PullRequestQuantifier customizations](https://github.com/microsoft/PullRequestQuantifier/blob/main/docs/prquantifier-yaml.md).Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean: - Fast and predictable releases to production: - Optimal size changes are more likely to be reviewed faster with fewer iterations. - Similarity in low PR complexity drives similar review times. - Review quality is likely higher as complexity is lower: - Bugs are more likely to be detected. - Code inconsistencies are more likely to be detetcted. - Knowledge sharing is improved within the participants: - Small portions can be assimilated better. - Better engineering practices are exercised: - Solving big problems by dividing them in well contained, smaller problems. - Exercising separation of concerns within the code changes. #### What can I do to optimize my changes - Use the PullRequestQuantifier to quantify your PR accurately - Create a context profile for your repo using the [context generator](https://github.com/microsoft/PullRequestQuantifier/releases) - Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the `Excluded` section from your `prquantifier.yaml` context profile. - Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your `prquantifier.yaml` context profile. - Only use the labels that matter to you, [see context specification](./docs/prquantifier-yaml.md) to customize your `prquantifier.yaml` context profile. - Change your engineering behaviors - For PRs that fall outside of the desired spectrum, review the details and check if: - Your PR could be split in smaller, self-contained PRs instead - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR). #### How to interpret the change counts in git diff output - One line was added: `+1 -0` - One line was deleted: `+0 -1` - One line was modified: `+1 -1` (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion) - Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.