search

sdttttt / gcr

📑 Compact specification git commit tool, it has a variety of practical small functions. (Inspired by git-cz on Node.js)
https://crates.io/crates/grc
The Unlicense
28 stars 6 forks source link

commits generated by grc are not properly signed #52

Open Enter-tainer opened 3 years ago

Enter-tainer commented 3 years ago

By default, if signingKey is specified in ~/.gitconfig, git will automatically sign the commit using gpg. But when using grc, commits are not signed.

git log --show-signature

image

My gitconfig:

mgt in ~
❯ cat .gitconfig
[user]
    name = mgt
    email = mgt@oi-wiki.org
    signingKey = 7965BF43A2143DD26F1A4850362C4BEE95C1C2DF
[commit]
    gpgSign = true

I've searched git2's document, and I guess it is possible to implement this feature. See https://docs.rs/git2/0.13.17/git2/struct.Repository.html#method.commit_signed .

CoelacanthusHex commented 3 years ago

I found a upstream discussion https://github.com/rust-lang/git2-rs/issues/507 , hope it can help you.

sdttttt commented 3 years ago

Hi, @CoelacanthusHex, @Enter-tainer Thank you for your issue. i would support for this feature in the next release.

I underestimated the difficulty of this job, I will support it as soon as possible if it is feasible.இ௰இ