search

sdu-cfei / mshoot

Multiple Shooting Model Predictive Control Framework
BSD 3-Clause "New" or "Revised" License
15 stars 8 forks source link

Add FMPy support #4

Open filokot opened 4 years ago

filokot commented 4 years ago

Add FMPy support: https://github.com/CATIA-Systems/FMPy/tree/master/fmpy

AwhLorraine commented 3 years ago

Hi I try to add Fmpy (https://github.com/CATIA-Systems/FMPy/tree/master/fmpy) support to mshoot. This is heavily inspired from the work in modestpy with Fmpy support (https://github.com/sdu-cfei/modest-py/blob/master/modestpy/fmi/model.py).

fmpy support.txt

Can you take a look at it? And send some feedback

Thanks

filokot commented 3 years ago

Hi,

Thank you for your effort! I will be able to look at the code around Jan. 20 at the earliest. Hope that others can correspond though - I will let them know just in case they miss a notification

All the best.

krzysztofarendt commented 3 years ago

Hello, I should be able to review the code within a week :) Thank you for your contribution.

AwhLorraine commented 3 years ago

Great! I was able to correct some mishapes in the code! You may review this version. fmpy support.txt

HNY to all you by the way!

krzysztofarendt commented 3 years ago

@AwhLorraine , could you please implement the proposed changes to your fork of mshoot and then create a pull request that we could review?

https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

That would make the reviewing process a lot smoother.

Also, is it possible to check if https://github.com/sdu-cfei/mshoot/blob/master/test/test_fmi.py works? If you're unsure how unit test works, you can leave this step to us.

Thanks!