search

sdv-dev / CTGAN

Conditional GAN for generating synthetic tabular data.
Other
1.23k stars 279 forks source link

CTGAN using deprecated 'sklearn' #350

Closed mtas0 closed 4 months ago

mtas0 commented 5 months ago

Environment Details

Hi, I cannot install ctgan because it still uses 'sklearn' as one of its dependencies, however 'sklearn' has been deprecated and 'scikit-learn' should be used instead.

Could you please update your dependencies so that scikit-learn is installed and not sklearn?

Thank you.

npatki commented 5 months ago

Hi @mtas0, nice to meet you.

It is my understanding that even when installing the latest version of scikit-learn, you can still use import sklearn within Python to refer to the same (newer) scikit-learn package.

I've double-checked the requirements in the latest CTGAN stable release. The CTGAN library is requiring scikit-learn. It sets a minimal version -- meaning that any newer version of the scikit-learn library should be compatible with it.

https://github.com/sdv-dev/CTGAN/blob/c258d865b4ae129e7ba424d0cb522d89c453432f/pyproject.toml#L28-L29

So I'm not sure why this particular requirement would blocking you from installation. Perhaps there is another library in your Python environment that is interfering? Happy to help you debug if you're able to provide more info -- is there an error message you're seeing?

npatki commented 4 months ago

Hi @mtas0, I'm closing this issue off since it has been inactive for a few weeks. Please feel free to reply if there's more to discuss on the topic. I can always re-open the issue. Thanks.