search

sdv-dev / SDMetrics

Metrics to evaluate quality and efficacy of synthetic datasets.
https://docs.sdv.dev/sdmetrics
MIT License
209 stars 44 forks source link

Noblemen - Kolmogorov–Smirnov #278

Closed akashmukherjee1985 closed 1 year ago

akashmukherjee1985 commented 1 year ago

Hello Team,

First of all many thanks for creating such a wonderful package. I tried the model method and it helps.

I read how the model evaluates base data and over-sampled data' overall score. It's interesting. So, I read about KS Complement. Here, 'KS' denotes the name Kolmogorov–Smirnov test statistics.

Just had an observation - on the Nobleman's name over your website. Snapshots attached.

Correct name can be found in wiki: https://en.wikipedia.org/wiki/Kolmogorov%E2%80%93Smirnov_test

So, if it is the same 'Kolmogorov', you would like to edit it. Or, please let me know if I missed anything. Thanks again for helping! Happy journey.

Best, friend

kol2 kol

npatki commented 1 year ago

Hi @akashmukherjee1985, thanks for catching this. The page should be updated now if you refresh the URL.

Here:

image

And here:

image

I'm marking this as resolved. Please feel free to reply if there's any spots I missed!