search

sdv-dev / SDMetrics

Metrics to evaluate quality and efficacy of synthetic datasets.
https://docs.sdv.dev/sdmetrics
MIT License
210 stars 45 forks source link

Fix `ValueError` in `NewRowSynthesis` if size of `row_filter` exceeds 31 #313

Closed frances-h closed 1 year ago

frances-h commented 1 year ago

Resolve #307

Set the query engine to 'python' if more than 31 row_filters are specified. Trying to use the default numexpr will result in a ValueError or Memory error if more than 31 row_filters are provided, probably due to numpy limiting NPY_MAXARGS=32.

codecov-commenter commented 1 year ago

Codecov Report

Base: 75.12% // Head: 75.21% // Increases project coverage by +0.09% :tada:

Coverage data is based on head (8a7545c) compared to base (95c9b16). Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #313 +/- ## ========================================== + Coverage 75.12% 75.21% +0.09% ========================================== Files 74 74 Lines 2991 2994 +3 ========================================== + Hits 2247 2252 +5 + Misses 744 742 -2 ``` | [Impacted Files](https://codecov.io/gh/sdv-dev/SDMetrics/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [sdmetrics/single\_table/new\_row\_synthesis.py](https://codecov.io/gh/sdv-dev/SDMetrics/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3NpbmdsZV90YWJsZS9uZXdfcm93X3N5bnRoZXNpcy5weQ==) | `93.65% <100.00%> (+3.65%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.