sdv-dev / SDMetrics

Metrics to evaluate quality and efficacy of synthetic datasets.
https://docs.sdv.dev/sdmetrics
MIT License
210 stars 45 forks source link

Better extra categoricals warning message #323

Closed frances-h closed 1 year ago

frances-h commented 1 year ago

Resolve #315

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 93.54% and project coverage change: +0.17 :tada:

Comparison is base (d5af0d1) 75.25% compared to head (30adeb3) 75.42%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #323 +/- ## ========================================== + Coverage 75.25% 75.42% +0.17% ========================================== Files 74 74 Lines 2998 3024 +26 ========================================== + Hits 2256 2281 +25 - Misses 742 743 +1 ``` | [Impacted Files](https://codecov.io/gh/sdv-dev/SDMetrics/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [sdmetrics/reports/utils.py](https://codecov.io/gh/sdv-dev/SDMetrics/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvdXRpbHMucHk=) | `98.62% <91.66%> (-0.87%)` | :arrow_down: | | [sdmetrics/reports/multi\_table/diagnostic\_report.py](https://codecov.io/gh/sdv-dev/SDMetrics/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvbXVsdGlfdGFibGUvZGlhZ25vc3RpY19yZXBvcnQucHk=) | `95.86% <100.00%> (+0.02%)` | :arrow_up: | | [sdmetrics/reports/multi\_table/quality\_report.py](https://codecov.io/gh/sdv-dev/SDMetrics/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvbXVsdGlfdGFibGUvcXVhbGl0eV9yZXBvcnQucHk=) | `96.38% <100.00%> (+0.02%)` | :arrow_up: | | [...dmetrics/reports/single\_table/diagnostic\_report.py](https://codecov.io/gh/sdv-dev/SDMetrics/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvc2luZ2xlX3RhYmxlL2RpYWdub3N0aWNfcmVwb3J0LnB5) | `98.18% <100.00%> (+0.01%)` | :arrow_up: | | [sdmetrics/reports/single\_table/quality\_report.py](https://codecov.io/gh/sdv-dev/SDMetrics/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvc2luZ2xlX3RhYmxlL3F1YWxpdHlfcmVwb3J0LnB5) | `99.11% <100.00%> (+<0.01%)` | :arrow_up: | | [sdmetrics/utils.py](https://codecov.io/gh/sdv-dev/SDMetrics/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3V0aWxzLnB5) | `91.15% <100.00%> (+0.71%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.