sdv-dev / SDMetrics

Metrics to evaluate quality and efficacy of synthetic datasets.
https://docs.sdv.dev/sdmetrics
MIT License
210 stars 45 forks source link

Issue 355 column shape property #366

Closed R-Palazzo closed 1 year ago

R-Palazzo commented 1 year ago

Resolve #355

I just have some questions:

Also, I think validate_single_table_inputs that is in sdmetrics.reports.utils could be modified to better validate the data and metadata. We can define a validation method inside BaseSingleTableProperty maybe.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.22 :tada:

Comparison is base (016e6c7) 75.94% compared to head (c8e6cbf) 76.16%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #366 +/- ## ========================================== + Coverage 75.94% 76.16% +0.22% ========================================== Files 79 80 +1 Lines 3101 3147 +46 ========================================== + Hits 2355 2397 +42 - Misses 746 750 +4 ``` | [Impacted Files](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [.../reports/single\_table/\_properties/column\_shapes.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvc2luZ2xlX3RhYmxlL19wcm9wZXJ0aWVzL2NvbHVtbl9zaGFwZXMucHk=) | `81.08% <81.08%> (ø)` | | | [sdmetrics/reports/single\_table/\_properties/base.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvc2luZ2xlX3RhYmxlL19wcm9wZXJ0aWVzL2Jhc2UucHk=) | `92.85% <90.00%> (-7.15%)` | :arrow_down: | | [...trics/reports/single\_table/\_properties/\_\_init\_\_.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvc2luZ2xlX3RhYmxlL19wcm9wZXJ0aWVzL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/366/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

R-Palazzo commented 1 year ago

Thanks @amontanez24 and @pvk-developer for your review. All comments are addressed in 8ec3992 and e78d307. ;)