search

sdv-dev / SDMetrics

Metrics to evaluate quality and efficacy of synthetic datasets.
https://docs.sdv.dev/sdmetrics
MIT License
210 stars 45 forks source link

Use property classes in multi table `QualityReport` #383

Closed fealho closed 1 year ago

fealho commented 1 year ago

Resolve #371, resolve #362

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 97.67% and project coverage change: -0.57 :warning:

Comparison is base (6580683) 76.96% compared to head (717bd05) 76.39%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #383 +/- ## ========================================== - Coverage 76.96% 76.39% -0.57% ========================================== Files 84 84 Lines 3369 3271 -98 ========================================== - Hits 2593 2499 -94 + Misses 776 772 -4 ``` | [Impacted Files](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/383?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [...rts/single\_table/\_properties/column\_pair\_trends.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/383?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvc2luZ2xlX3RhYmxlL19wcm9wZXJ0aWVzL2NvbHVtbl9wYWlyX3RyZW5kcy5weQ==) | `87.43% <ø> (ø)` | | | [sdmetrics/reports/single\_table/quality\_report.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/383?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvc2luZ2xlX3RhYmxlL3F1YWxpdHlfcmVwb3J0LnB5) | `98.87% <ø> (ø)` | | | [sdmetrics/warnings.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/383?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3dhcm5pbmdzLnB5) | `100.00% <ø> (ø)` | | | [sdmetrics/reports/multi\_table/quality\_report.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/383?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvbXVsdGlfdGFibGUvcXVhbGl0eV9yZXBvcnQucHk=) | `98.61% <97.67%> (+2.16%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/383/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.