search

sdv-dev / SDMetrics

Metrics to evaluate quality and efficacy of synthetic datasets.
https://docs.sdv.dev/sdmetrics
MIT License
210 stars 45 forks source link

Fix Single Table Quality Report rounding #421

Closed fealho closed 1 year ago

fealho commented 1 year ago

Resolve #419.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d34cae0) 77.24% compared to head (70fa29f) 77.24%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #421 +/- ## ======================================= Coverage 77.24% 77.24% ======================================= Files 83 83 Lines 3384 3384 ======================================= Hits 2614 2614 Misses 770 770 ``` | [Files Changed](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [sdmetrics/reports/single\_table/quality\_report.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvc2luZ2xlX3RhYmxlL3F1YWxpdHlfcmVwb3J0LnB5) | `98.87% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fealho commented 1 year ago

@R-Palazzo Yep. Only thing that happens now is it returns a single digit sometimes (e.g. 10.8% instead of 10.80%), which I think is fine.