search

sdv-dev / SDMetrics

Metrics to evaluate quality and efficacy of synthetic datasets.
https://docs.sdv.dev/sdmetrics
MIT License
210 stars 45 forks source link

Add `get_column_pair_plot` #457

Closed pvk-developer closed 1 year ago

pvk-developer commented 1 year ago

Resolves #444

image image image image
npatki commented 1 year ago

I realized that when you switch the column order, it changes the boxplot orientation. Maybe that's something we can change here, always to have the categorical column on thex-axis and the continuous column on they-axis (or the reverse). @npatki does it make sense?

For now, this is working as intended. We weren't sure which people would like more, and it's easy to switch the column order (in the input) to get the orientation you want.

codecov-commenter commented 1 year ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (efeb278) 76.54% compared to head (a97f3db) 76.14%. Report is 2 commits behind head on main.

:exclamation: Current head a97f3db differs from pull request most recent head f0a9fe2. Consider uploading reports for the commit f0a9fe2 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #457 +/- ## ========================================== - Coverage 76.54% 76.14% -0.40% ========================================== Files 92 91 -1 Lines 3359 3307 -52 ========================================== - Hits 2571 2518 -53 - Misses 788 789 +1 ``` | [Files](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/457?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [sdmetrics/reports/utils.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/457?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvdXRpbHMucHk=) | `86.31% <ø> (-7.56%)` | :arrow_down: | | [sdmetrics/visualization.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/457?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3Zpc3VhbGl6YXRpb24ucHk=) | `94.73% <96.00%> (+3.82%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.