sdv-dev / SDMetrics

Metrics to evaluate quality and efficacy of synthetic datasets.
https://docs.sdv.dev/sdmetrics
MIT License
210 stars 45 forks source link

Validate that the metadata is always a dict #466

Closed R-Palazzo closed 1 year ago

R-Palazzo commented 1 year ago

Resolve #428

codecov-commenter commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (bc92a5e) 76.84% compared to head (cc6a105) 76.87%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #466 +/- ## ========================================== + Coverage 76.84% 76.87% +0.02% ========================================== Files 93 93 Lines 3395 3395 ========================================== + Hits 2609 2610 +1 + Misses 786 785 -1 ``` | [Files](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [sdmetrics/reports/base\_report.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvYmFzZV9yZXBvcnQucHk=) | `100.00% <100.00%> (+1.05%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

npatki commented 1 year ago

@R-Palazzo we should not be accepting the actual metadata object. We should only accept dictionaries.

I would avoid doing any conversions in SDMetrics and stick to the original issue.