search

sdv-dev / SDMetrics

Metrics to evaluate quality and efficacy of synthetic datasets.
https://docs.sdv.dev/sdmetrics
MIT License
201 stars 44 forks source link

Add `Relationship Validity` property #488

Closed R-Palazzo closed 10 months ago

R-Palazzo commented 10 months ago

CU-86ayg9y9r Resolve #469

The visualization is @npatki :

Screenshot 2023-10-31 at 09 18 58
codecov-commenter commented 10 months ago

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (960e4a8) 77.83% compared to head (40d005c) 78.39%. Report is 23 commits behind head on diagnostic_report_updates.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## diagnostic_report_updates #488 +/- ## ============================================================= + Coverage 77.83% 78.39% +0.55% ============================================================= Files 100 103 +3 Lines 3574 3680 +106 ============================================================= + Hits 2782 2885 +103 - Misses 792 795 +3 ``` | [Files](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [sdmetrics/\_\_init\_\_.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL19faW5pdF9fLnB5) | `80.00% <100.00%> (ø)` | | | [sdmetrics/column\_pairs/\_\_init\_\_.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL2NvbHVtbl9wYWlycy9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [sdmetrics/column\_pairs/statistical/\_\_init\_\_.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL2NvbHVtbl9wYWlycy9zdGF0aXN0aWNhbC9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [...airs/statistical/cardinality\_boundary\_adherence.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL2NvbHVtbl9wYWlycy9zdGF0aXN0aWNhbC9jYXJkaW5hbGl0eV9ib3VuZGFyeV9hZGhlcmVuY2UucHk=) | `100.00% <100.00%> (ø)` | | | [.../column\_pairs/statistical/referential\_integrity.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL2NvbHVtbl9wYWlycy9zdGF0aXN0aWNhbC9yZWZlcmVudGlhbF9pbnRlZ3JpdHkucHk=) | `100.00% <100.00%> (ø)` | | | [...etrics/reports/multi\_table/\_properties/\_\_init\_\_.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvbXVsdGlfdGFibGUvX3Byb3BlcnRpZXMvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [...ics/reports/multi\_table/\_properties/cardinality.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvbXVsdGlfdGFibGUvX3Byb3BlcnRpZXMvY2FyZGluYWxpdHkucHk=) | `100.00% <100.00%> (ø)` | | | [...s/reports/multi\_table/\_properties/data\_validity.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvbXVsdGlfdGFibGUvX3Byb3BlcnRpZXMvZGF0YV92YWxpZGl0eS5weQ==) | `100.00% <100.00%> (ø)` | | | [...orts/multi\_table/\_properties/inter\_table\_trends.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvbXVsdGlfdGFibGUvX3Byb3BlcnRpZXMvaW50ZXJfdGFibGVfdHJlbmRzLnB5) | `100.00% <100.00%> (ø)` | | | [...s/multi\_table/\_properties/relationship\_validity.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvbXVsdGlfdGFibGUvX3Byb3BlcnRpZXMvcmVsYXRpb25zaGlwX3ZhbGlkaXR5LnB5) | `100.00% <100.00%> (ø)` | | | ... and [14 more](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/488?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

R-Palazzo commented 10 months ago

Thanks for the review @frances-h, I addressed the comments ;)