sdv-dev / SDMetrics

Metrics to evaluate quality and efficacy of synthetic datasets.
https://docs.sdv.dev/sdmetrics
MIT License
210 stars 45 forks source link

Make quality reports fault tolerant on missing relationships in metadata #489

Closed lajohn4747 closed 1 year ago

lajohn4747 commented 1 year ago

CU-86ayjkavn

86ayjkavn

resolves #481

Missing relationship metadata no longer throws an error but instead returns NaN for the score report for multitable data.

codecov-commenter commented 1 year ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b1853d9) 77.07% compared to head (6dc6cd1) 77.02%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #489 +/- ## ========================================== - Coverage 77.07% 77.02% -0.06% ========================================== Files 93 93 Lines 3416 3425 +9 ========================================== + Hits 2633 2638 +5 - Misses 783 787 +4 ``` | [Files](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [...orts/multi\_table/\_properties/inter\_table\_trends.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvbXVsdGlfdGFibGUvX3Byb3BlcnRpZXMvaW50ZXJfdGFibGVfdHJlbmRzLnB5) | `100.00% <100.00%> (ø)` | | | [sdmetrics/reports/multi\_table/\_properties/base.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvbXVsdGlfdGFibGUvX3Byb3BlcnRpZXMvYmFzZS5weQ==) | `94.59% <73.33%> (-5.41%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.