search

sdv-dev / SDMetrics

Metrics to evaluate quality and efficacy of synthetic datasets.
https://docs.sdv.dev/sdmetrics
MIT License
201 stars 44 forks source link

Fix: Sometimes graphs not being generated in jupyter notebook #497

Closed pvk-developer closed 10 months ago

pvk-developer commented 10 months ago

CU-860q76vnz Resolves #322

Add a function to set the plotly default render depending on the environment.

Here is a notebook in google colab that maintains the functionality there. Please try in a local environment to ensure that the iframe engine is being used.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d7a8888) 76.97% compared to head (f5dd24a) 77.03%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #497 +/- ## ========================================== + Coverage 76.97% 77.03% +0.05% ========================================== Files 93 93 Lines 3427 3448 +21 ========================================== + Hits 2638 2656 +18 - Misses 789 792 +3 ``` | [Files](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/497?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [sdmetrics/reports/base\_report.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/497?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvYmFzZV9yZXBvcnQucHk=) | `100.00% <100.00%> (ø)` | | | [...ics/reports/multi\_table/base\_multi\_table\_report.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/497?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3JlcG9ydHMvbXVsdGlfdGFibGUvYmFzZV9tdWx0aV90YWJsZV9yZXBvcnQucHk=) | `100.00% <100.00%> (ø)` | | | [sdmetrics/visualization.py](https://app.codecov.io/gh/sdv-dev/SDMetrics/pull/497?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RtZXRyaWNzL3Zpc3VhbGl6YXRpb24ucHk=) | `93.95% <82.35%> (-1.50%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

R-Palazzo commented 10 months ago

Looks good. I tried on vscode I got 'vscode' renderers as expected, but on Jupyter notebook I got plotly_mimetype+notebook renderers and the graphs didn't show up in the jupyter notebook. I'm getting this in jupyter notebook:

Screenshot 2023-11-06 at 16 15 29

However on VSCode it's showing up:

Screenshot 2023-11-06 at 16 16 56
sdv-team commented 10 months ago

Task linked: CU-860q76vnz SDMetrics - Sometimes graphs don't show when using Jupyter notebook #322