sdv-dev / SDMetrics

Metrics to evaluate quality and efficacy of synthetic datasets.
https://docs.sdv.dev/sdmetrics
MIT License
210 stars 45 forks source link

Report `validate` method should be private #507

Closed frances-h closed 11 months ago

frances-h commented 12 months ago

Environment Details

Please indicate the following details about the environment in which you found the bug:

Error Description

Currently, the validate method on BaseReport is a public method. This should be changed to a private method (_validate) as it is not part of the public API.

Steps to reproduce

from sdmetrics.reports.single_tableimport QualityReport

report = QualityReport()
report.validate(real_data, synthetic_data, metadata)