search

sdv-dev / SDV

Synthetic data generation for tabular data
https://docs.sdv.dev/sdv
Other
2.21k stars 287 forks source link

Rename file_path to filepath parameter in ExcelHandler #2058

Closed amontanez24 closed 2 weeks ago

amontanez24 commented 2 weeks ago

resolves #2055 CU-86b0vmmft

sdv-team commented 2 weeks ago

Task linked: CU-86b0vmmft SDV - Rename file_path to filepath parameter in ExcelHandler #2055

amontanez24 commented 2 weeks ago

LGTM, just noting this is a breaking API change

Yeah. This feature is listed as in beta in our docs, so we're taking some liberty with how much we can change it.

Also in our docs we specify that our docs are the source of truth for the API. So if the docs show one thing and the code is another, we've been treating that as a "bug". In this case the docs were changed but then we agreed to change it back