sdv-dev / SDV

Synthetic data generation for tabular data
https://docs.sdv.dev/sdv
Other
2.39k stars 317 forks source link

Update integer boundaries for ID columns #2282

Closed R-Palazzo closed 2 weeks ago

R-Palazzo commented 2 weeks ago

Resolve #2285 I set the max boundary to work with pa.float32 so all the benchmark dtypes also work.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.64%. Comparing base (315266f) to head (bb24d2c). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2282 +/- ## ========================================== - Coverage 98.64% 98.64% -0.01% ========================================== Files 58 58 Lines 6035 6034 -1 ========================================== - Hits 5953 5952 -1 Misses 82 82 ``` | [Flag](https://app.codecov.io/gh/sdv-dev/SDV/pull/2282/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sdv-dev) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/sdv-dev/SDV/pull/2282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sdv-dev) | `82.16% <71.42%> (-0.04%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/sdv-dev/SDV/pull/2282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sdv-dev) | `97.46% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sdv-dev#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.