search

sdv-dev / SDV

Synthetic data generation for tabular data
https://docs.sdv.dev/sdv
Other
2.39k stars 317 forks source link

Modularize `validate` method for multi-table synthesizers #2292

Closed frances-h closed 1 week ago

frances-h commented 1 week ago

Resolve #2291

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.66%. Comparing base (4d56fe7) to head (412f3f0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2292 +/- ## ========================================== + Coverage 98.64% 98.66% +0.01% ========================================== Files 58 58 Lines 6043 6045 +2 ========================================== + Hits 5961 5964 +3 + Misses 82 81 -1 ``` | [Flag](https://app.codecov.io/gh/sdv-dev/SDV/pull/2292/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sdv-dev) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/sdv-dev/SDV/pull/2292/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sdv-dev) | `82.21% <100.00%> (+0.02%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/sdv-dev/SDV/pull/2292/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sdv-dev) | `97.46% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sdv-dev#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

frances-h commented 1 week ago

Out of scope for now, closing