Number of epochs does not match your homepage docs and example

sdv-dev / TGAN

Generative adversarial training for generating synthetic tabular data.

MIT License

281 stars 91 forks source link

Number of epochs does not match your homepage docs and example #37

Open tirthajyoti opened 5 years ago

tirthajyoti commented 5 years ago

Hi,

Thanks for this excellent implementation. I am trying it out now. Your homepage docs and the Jupyter notebook example say max_epoch=100 but in fact, in the latest install, it is set to 5.

Please reconcile the descriptions. The model is computationally heavy, so it is good to have a realistic expectation about the epochs to run before one starting fitting :-)

csala commented 5 years ago

Thanks for pointing this out @tirthajyoti !

We'll change the notebook and README asap to match the code (unless you want to do a PR that changes it ;-)

MariamDundua commented 3 years ago

Does five epoch is enough for 2000000x20 size dataframe? What is recommended one for this size of dataframe