search

sdwebui-w-horde / sd-webui-stable-horde-worker

Stable Horde Unofficial Worker Bridge as Stable Diffusion WebUI (AUTOMATIC1111) Extension
GNU Affero General Public License v3.0
60 stars 18 forks source link

feat: Save Images #25

Closed john-warnes closed 1 year ago

john-warnes commented 1 year ago

Enjoyed you extension! Thanks! It's a fun way to try out stable horde. I thought I would also share.

I fixed a bug in the branch get it to work, and added a save feature to see what people have been generating when I am away.

Bug Seed was being send as a string when stable horde wants a int. returned at 400 error.

New feature "Save Images"

Note If you don't go into the settings and enable all the Real-ESRGAN models under "Upscaling" you will get errors when the horde uses them.

I hope it's a welcome pull request, but If this is unwanted go ahead and close the request.

MaikoTan commented 1 year ago

Thanks for contributing the feature and bug fixes! I think this feature is good.

Since you're opening a PR that is based the branch tab-page, I want to do some test before and after merging your PR to make sure it is functioning properly.

MaikoTan commented 1 year ago

By the way, I'm going to cherry-pick your bug-fixing commit to the main branch first, since this is an emergence bug that should be fixed quickly.

MaikoTan commented 1 year ago

Note If you don't go into the settings and enable all the Real-ESRGAN models under "Upscaling" you will get errors when the horde uses them.

So, is there any approach to "force" users to enable all the Real-ESRGAN models before enabling this extension? Honestly I am not familiar with Python or even SD-WebUI stuffs, I thought the only way was to write a detailed guide on our tab page to notify users to check if they have all the Real-ESRGAN models enabled?

MaikoTan commented 1 year ago

(Sorry but it seems like I have broken your branch unexpectedly, can you rebase your branch to the main branch manually once?)

john-warnes commented 1 year ago

(Sorry but it seems like I have broken your branch unexpectedly, can you rebase your branch to the main branch manually once?)

Can do but, Did you still need this?

MaikoTan commented 1 year ago

(Sorry but it seems like I have broken your branch unexpectedly, can you rebase your branch to the main branch manually once?)

Can do but, Did you still need this?

Yes, please.

By the way, would you mind joining our github organisation? I would send you an invitation if you don't mind.

MaikoTan commented 1 year ago

So I try to do the changes by myself, sorry.