Add header guards - Githubissues

sdwfrost / liblsoda

The LSODA algorithm for differential equations as a shared library

MIT License

32 stars 16 forks source link

Add header guards #1

Closed richfitz closed 8 years ago

richfitz commented 8 years ago

Nice job on this. I've got the R version essentially working (https://github.com/richfitz/rlsoda), and looking potentially quite a bit faster than the deSolve/Fortran versions (mostly because of some issues in deSolve I believe).

I have a bunch of other things I'd like to change (fixing compiler warnings, avoiding abort). Some of these will be helpful for a Julia library. Would you like these as issues, several PRs or one big PR?

sdwfrost commented 8 years ago

Dear @richfitz

There are a number of things I'd like to change too:

One may need to have access to lsoda_common_t. Perhaps a separate header in include/ to capture that?
I had one compiler warning about an unused variables that I couldn't fathom; if you get more, feel free to fix

If you already have a fix in hand, just submit small PRs; if you've lined it up, but haven't got round to it, please file an issue.