sdyinzhen / MPS-BedMappingV1

This is the python opensource repo for basal mapping from radar line data using multiple-point geostatistics (MPS)
MIT License
8 stars 1 forks source link

Review of MPS-BedMappingV1 #1

Closed weiji14 closed 2 years ago

weiji14 commented 3 years ago

Hi @sdyinzhen,

Great work on your paper :smile:. I'm attaching the markdown (plaintext) version of my review comment (https://doi.org/10.5194/gmd-2021-297-RC2) here for your reference. This should hopefully save you some time with not having to copy and paste out of a PDF for the corrections step later (something I got annoyed with for my paper last year).

gmd-2021-297-RC2.md

Let me know too if you need any clarification, or if you need help with anything. Good luck!

sdyinzhen commented 3 years ago

Thank you so much for your supportive comments and markdown file, Wei Ji! We will revise the paper based on your comments :).

Best wishes, David

On Mon, 4 Oct 2021 at 22:12, Wei Ji @.***> wrote:

Hi @sdyinzhen https://github.com/sdyinzhen,

Great work on your paper 😄. I'm attaching the markdown (plaintext) version of my review comment (https://doi.org/10.5194/gmd-2021-297-RC2) here for your reference. This should hopefully save you some time with not having to copy and paste out of a PDF for the corrections step later (something I got annoyed with for my paper last year).

gmd-2021-297-RC2.md https://github.com/sdyinzhen/MPS-BedMappingV1/files/7282882/gmd-2021-297-RC2.md

Let me know too if you need any clarification, or if you need help with anything. Good luck!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sdyinzhen/MPS-BedMappingV1/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIUI54EX7WJZG7QC2NHIGBTUFKCM7ANCNFSM5FK4KKFQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

sdyinzhen commented 2 years ago

Hi Weiji,

I just noticed that you joined my AGU live session today. Sorry I left the Zoom session just minutes before you joined. Please let me know if you still want to discuss. We can create a new zoom :).

Cheers, David

On Mon, 4 Oct 2021 at 22:12, Wei Ji @.***> wrote:

Hi @sdyinzhen https://github.com/sdyinzhen,

Great work on your paper 😄. I'm attaching the markdown (plaintext) version of my review comment (https://doi.org/10.5194/gmd-2021-297-RC2) here for your reference. This should hopefully save you some time with not having to copy and paste out of a PDF for the corrections step later (something I got annoyed with for my paper last year).

gmd-2021-297-RC2.md https://github.com/sdyinzhen/MPS-BedMappingV1/files/7282882/gmd-2021-297-RC2.md

Let me know too if you need any clarification, or if you need help with anything. Good luck!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sdyinzhen/MPS-BedMappingV1/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIUI54EX7WJZG7QC2NHIGBTUFKCM7ANCNFSM5FK4KKFQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

weiji14 commented 2 years ago

Oh hi @sdyinzhen, yes I woke up a bit too late (it's like 6am...) so thought you might have left already. I'm free now so will wait for you in the same Zoom meeting you created just now.

sdyinzhen commented 2 years ago

sounds great @weiji14. Here here is the link: https://stanford.zoom.us/j/99416623683?pwd=Q2FGNmU5eWRsdjJyMFNwZDJQRm1UUT09
pwd: 244083

weiji14 commented 2 years ago

Hmm, it says the link is invalid, could you double check?

sdyinzhen commented 2 years ago

Sorry, some technical issues. Can we still use the AGU one?

sdyinzhen commented 2 years ago

In case : https://stanford.zoom.us/j/98871099225?pwd=ME5sd3ZRenhEYUN5cFNXaXRJZlFoUT09 pwd: 134126

weiji14 commented 2 years ago

Cool, thanks for the chat @sdyinzhen. We'll keep in touch :smile:

sdyinzhen commented 2 years ago

Nice to chat with you Wei Ji. I just uploaded the DS simulation results to the repo: https://github.com/sdyinzhen/MPS-BedMappingV1/tree/main/results . Will update the notebooks accordingly.