Closed ernestlim8 closed 3 years ago
Click here to submit a new iteration when this PR is ready for review.
See this repository's contribution guide for more information.
I realised that the format for the summary of the Logic component is slightly different from the other components, where it does not have this part.
The `Storage` component,
* can save `UserPref` objects in json format and read it back.
* can save the address book data in json format and read it back.
* depends on the Model component.
I think something like this might be better to match the format.
The `Logic` component,
* can parse commands using `AddressBookParser`
* can execute commands
* depends on some classes in the Model and Storage components (because the `Logic` component's job
is to modify objects of the `Model` class and store those objects using the `Storage` component)
@ernestlim8 submitted v1 for review.
Merging #103 (052ffb4) into master (1de4e80) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #103 +/- ##
=========================================
Coverage 72.15% 72.15%
Complexity 399 399
=========================================
Files 70 70
Lines 1232 1232
Branches 125 125
=========================================
Hits 889 889
Misses 311 311
Partials 32 32
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1de4e80...052ffb4. Read the comment docs.
@ernestlim8 submitted v2 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2) (:chart_with_upwards_trend: Range-Diff between v1 and v2)
@ernestlim8 submitted v3 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3) (:chart_with_upwards_trend: Range-Diff between v2 and v3)
@ernestlim8 submitted v4 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v3 and v4) (:chart_with_upwards_trend: Range-Diff between v3 and v4)
@ernestlim8 shall we finish this PR?
@ernestlim8 submitted v5 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v4 and v5) (:chart_with_upwards_trend: Range-Diff between v4 and v5)
Fixes #94