search

se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 415 forks source link

Remove unnecessary call to super in inherited classes #118

Closed JinHao-L closed 2 years ago

JinHao-L commented 2 years ago

Fixes #83

Removes unnecessary super() call in StorageManager, ModelManager & UiManager

canihasreview[bot] commented 2 years ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

canihasreview[bot] commented 2 years ago

v1

@JinHao-L submitted v1 for review.

(:books: Archive)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/118/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
codecov-commenter commented 2 years ago

Codecov Report

Merging #118 (edcb774) into master (ba53b8c) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #118   +/-   ##
=========================================
  Coverage     72.15%   72.15%           
  Complexity      399      399           
=========================================
  Files            70       70           
  Lines          1232     1232           
  Branches        125      125           
=========================================
  Hits            889      889           
  Misses          311      311           
  Partials         32       32
Impacted Files Coverage Δ
...rc/main/java/seedu/address/model/ModelManager.java 100.00% <ø> (ø)
...ain/java/seedu/address/storage/StorageManager.java 94.44% <ø> (ø)
src/main/java/seedu/address/ui/UiManager.java 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba53b8c...edcb774. Read the comment docs.

damithc commented 2 years ago

Thanks for the PR @JinHao-L Probably no need to split into three separate commits?

JinHao-L commented 2 years ago

Thanks for the suggestion. I have merged the 3 commits into 1. :+1:

damithc commented 2 years ago

Thanks for the suggestion. I have merged the 3 commits into 1. 👍

Thanks @JinHao-L Please submit the new version as a new iteration using the CanIHasReview-bot

canihasreview[bot] commented 2 years ago

v2

@JinHao-L submitted v2 for review.

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2) (:chart_with_upwards_trend: Range-Diff between v1 and v2)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/118/2/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
damithc commented 2 years ago

Thanks for the fix @JinHao-L and @kouyk for the review. Note: I shortened the commit message a bit.