se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 415 forks source link

Help needed in smoke-testing the new release #120

Closed damithc closed 1 year ago

damithc commented 2 years ago

@se-edu/tech-team-level1 (newly inducted members in particular) I've created a new release with the latest changes. Please help smoke test it in your computer. Ensure you are using Java 11. If you are using Mac M1, ensure you have followed these instructions (see advisory for Mac users) to install the specific version of Java specified.

After testing, please post a screenshot of the GUI in this thread. I would like to see how it looks in various environments, given the change in concern is about fonts.

JoelHo commented 2 years ago

On Windows 11 Build 22000.376, Java version "11.0.11" 2021-04-20 LTS Everything looks normal on my system.

@damithc I think you meant to link the Java install instructions for M1 but the link is broken?

image image

damithc commented 2 years ago

@damithc I think you meant to link the Java install instructions for M1 but the link is broken?

Yup. Thx for the catch @JoelHo. Fixed.

kouyk commented 2 years ago

System: NixOS (another linux distro) JDK: openjdk 11.0.12 2021-07-20 (with openjfx11 installed)

I do have the required fonts installed on my system so everything looks as it should.

image image

chownces commented 2 years ago

I believe the font issue exists on certain JDKs on Intel Macs too. The Azul build works properly though.

This issue was also mentioned by a few other Intel Mac users last sem https://github.com/nus-cs2103-AY2122S1/forum/issues/231#issuecomment-936024007 https://github.com/nus-cs2103-AY2122S1/forum/issues/118

OS: MacOS Monterey (Intel)

JDK: openjdk 11.0.12 (Homebrew)

image

JDK: openjdk 11.0.13 (Azul)

image image
JinHao-L commented 2 years ago

System: Ubuntu 20.04 JDK: openjdk version "11.0.13" 2021-10-19

AB3 program runs well and looks normal on Ubuntu OS

Screenshot 2022-01-13 13:36:23

Tianqi-Zhu commented 2 years ago

System: Ubuntu 18.04 JDK: openjdk 11.0.13

image image

When I tried to resize it by dragging the left or right, there was some white flickering on the right. When I tried to resize it by dragging the top or the bottom, there was some white flickering at the bottom. image

LimJunxue commented 2 years ago

Windows 10, java version "11.0.13" 2021-10-19 LTS Program and functions look good to me.

image image

vimuthm commented 2 years ago

System: Windows 11 Build 22471.1000 JDK: openjdk 11.0.9.1 2020-11-04

Looks good!

image

For System: Ubuntu 20.04.3 LTS and JDK: openjdk 11.0.11 2021-04-20, I see no font problems but get the same flickering issue that @Tianqi-Zhu pointed out.

eeliana commented 2 years ago

OS: MacOS Big Sur (Intel)

Same problem as @\chownces with openjdk 11.0.12 (Homebrew) on Intel Mac. image

openjdk 11.0.9.1 2020-11-04 (AdoptOpenJDK)

image image

Py0000 commented 2 years ago

Tested the functionalities and checked the fonts. Everything looks good and works on my devices!

Test 1 System: Windows 10 Home (OS Build: 18363.1556) Java Version: 11.0.9 2020-10-20

image

Test 2 System: Windows 10 Home (OS Build: 19043.1415) Java Version: 11.0.10 2021-01-19

image

CrownKira commented 2 years ago

macOS version 12.0.1 (21A559), java 11.0.9 2020-10-20 LTS

All functionalities seem to work fine. no font issues or flickering issues.

Screenshot 2022-01-13 at 2 33 27 PM
HolmesJJ commented 2 years ago

Windows 10

System: Windows 10 Home 19043.1415 JDK: openjdk 11.0.9

GUI works well (light mode and dark mode both), functions works well. image image

macOS

System: macOS Big Sur Version 11.6 JDK: openjdk 11.0.8 (AdoptOpenJDK)

GUI works well (light mode and dark mode both), functions works well. image image

System: macOS Big Sur Version 11.6 JDK: openjdk 11.0.12 (Homebrew)

GUI font display error mentioned above. image image

Ubuntu

System: Ubuntu 18.04.5 LTS JDK: javac 11.0.13

GUI works well, functions works well. image image

I also reproduced the white flickering issue mentioned above, but I don't think this is the application bug since I tested other applications on my PC and all of them have the same white flickering issue.

jayasting98 commented 2 years ago

Ubuntu 20.04

Ubuntu 20.04.2 LTS (Running via Windows 10 WSL 2) openjdk version "11.0.11" 2021-04-20 (OpenJDK) Using XMing for display.

image

The dropdowns are strange, they are detached: image

The help window also does not seem work properly: image

It has similar problems on resizing that @Tianqi-Zhu found.

Windows 10

Windows 10 Build 19042.1415 java version "11.0.12" 2021-07-20 LTS (Oracle)

image

image

Looks fine overall. No problems found for Windows 10, even the resizing one.

kingsleykuan commented 2 years ago

Ubuntu 18.04

System: Ubuntu 18.04.6 (with Arc-Dark theme) Java: OpenJDK 11.0.13

Everything looks normal on my system, including the help window.

Screenshot from 2022-01-14 12-42-43

The dropdown menus are also working as intended.

Screenshot from 2022-01-14 12-50-36

I do notice the issue mentioned by @Tianqi-Zhu however it is a momentary flicker and not very noticeable.

jeffsieu commented 2 years ago

Everything looks normal. There are no flickering issues when resizing.

System information

Screenshots

image image

damithc commented 2 years ago

Thanks everyone for reporting smoke-testing results. @kouyk and others,

  1. I guess the font problem on Mac is expected and no action needed.
  2. How about the Ui anomalies reported on some Ubuntu environments? Is there a workaround?
kouyk commented 2 years ago
  1. How about the Ui anomalies reported on some Ubuntu environments? Is there a workaround?

The Ui anomalies seems to be applicable to Linux based systems as a whole, as I am also able to reproduce the same issue. My findings are similar to @HolmesJJ where it is not limited to AB3, I tried out recaf, another JavaFX application, which has a similar issue. Some quick googling seems to reveal that this is an upstream bug with JavaFX that has yet been resolved even for JavaFX 18, more details here. If launching via CLI, it may be possible to pass the flag -Dprism.forceUploadingPainter=true to java and reduce the severity of the problem.

It is unlikely that we are able to find a proper resolution or workaround for this issue, furthermore this is a minor cosmetic bug that does not impact normal usage of the application.

damithc commented 2 years ago

The Ui anomalies seems to be applicable to Linux based systems as a whole, as I am also able to reproduce the same issue. My findings are similar to @HolmesJJ where it is not limited to AB3, I tried out recaf, another JavaFX application, which has a similar issue. Some quick googling seems to reveal that this is an upstream bug with JavaFX that has yet been resolved even for JavaFX 18, more details here. If launching via CLI, it may be possible to pass the flag -Dprism.forceUploadingPainter=true to java and reduce the severity of the problem.

It is unlikely that we are able to find a proper resolution or workaround for this issue, furthermore this is a minor cosmetic bug that does not impact normal usage of the application.

Got it. We can leave it be. Students using the affected OS should already be familiar with the problem by the time they reach the PE, which means they will not report it as a bug of the software.

damithc commented 2 years ago

@se-edu/tech-team-level1 There's one student reporting that he is still facing the font problem https://github.com/nus-cs2103-AY2122S2/forum/issues/44#issuecomment-1022963388

Could you guys help follow up?

kouyk commented 2 years ago

Could you guys help follow up?

Seems to be resolved, which stems from the fact that multiple versions of JDK are installed and MacOS defaulting to the highest available version when launching any jar files via the GUI. There is a method to workaround that, perhaps someone on MacOS can try it out and provide a few screenshots so the advisory can be updated accordingly?

damithc commented 2 years ago

@se-edu/tech-team-level1 This might need your help as well https://github.com/nus-cs2103-AY2122S2/forum/issues/66

damithc commented 2 years ago

@se-edu/tech-team-level1 Another case https://github.com/nus-cs2103-AY2122S2/forum/issues/58#issuecomment-1025631708

Says he is not using a M1 Mac but facing a similar issue