se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 415 forks source link

Add wildcard parameterized type #121

Closed yhtMinceraft1010X closed 2 years ago

yhtMinceraft1010X commented 2 years ago

Part of #122

Proposed commit message:

The assertParseSuccess and assertParseFailure parameter parser
uses raw type for Parser. This would give a warning under to 
javac -Xlint:rawtypes.

Let's add a wildcard type parameter to Parser.

Screenshot (68)

canihasreview[bot] commented 2 years ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

canihasreview[bot] commented 2 years ago

v1

@yhtMinceraft1010X submitted v1 for review.

(:books: Archive)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/121/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
damithc commented 2 years ago

Thanks very much for the PR @yhtMinceraft1010X @se-edu/tech-team-level1 for your review please ...

jayasting98 commented 2 years ago

That seems to remove that warning. This change seems fine to me.

damithc commented 2 years ago

Thanks all for the reviews. @yhtMinceraft1010X perhaps we can omit Intellij from the commit message? Rationale: as this a improvement to the code, we should be able to justify it without relying on an IDE warning. Don't forget to wrap the body at 70 chars, not 50 chars.

yhtMinceraft1010X commented 2 years ago

Thanks Prof! I have fixed the commit message

canihasreview[bot] commented 2 years ago

v2

@yhtMinceraft1010X submitted v2 for review.

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2) (:chart_with_upwards_trend: Range-Diff between v1 and v2)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/121/2/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
damithc commented 2 years ago

Thanks for the fix @yhtMinceraft1010X Note that I revised the commit message a bit when merging.