Closed yhtMinceraft1010X closed 2 years ago
Click here to submit a new iteration when this PR is ready for review.
See this repository's contribution guide for more information.
@yhtMinceraft1010X submitted v1 for review.
Thanks very much for the PR @yhtMinceraft1010X @se-edu/tech-team-level1 for your review please ...
That seems to remove that warning. This change seems fine to me.
Thanks all for the reviews. @yhtMinceraft1010X perhaps we can omit Intellij from the commit message? Rationale: as this a improvement to the code, we should be able to justify it without relying on an IDE warning. Don't forget to wrap the body at 70 chars, not 50 chars.
Thanks Prof! I have fixed the commit message
@yhtMinceraft1010X submitted v2 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2) (:chart_with_upwards_trend: Range-Diff between v1 and v2)
Thanks for the fix @yhtMinceraft1010X Note that I revised the commit message a bit when merging.
Part of #122
Proposed commit message: