Upgrade Checkstyle to 9.3

se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)

https://se-education.org/addressbook-level3

MIT License

28 stars 415 forks source link

Upgrade Checkstyle to 9.3 #124

Closed yhtMinceraft1010X closed 2 years ago

yhtMinceraft1010X commented 2 years ago

The current build.gradle lists 8.29 as the version for Checkstyle. However, Checkstyle 9.3 is currently the latest version available. I propose upgrading Checkstyle to it.

I have done something similar for RepoSense. However, some of the new checks may not be as relevant since they are for proposed new Javadoc standards within RepoSense only.

damithc commented 2 years ago

Thanks for proposing this @yhtMinceraft1010X We can probably tackle this over the summer when AB3 is not in active use.

yhtMinceraft1010X commented 2 years ago

Here are my planned changes to address this issue:

Upgrade to Checkstyle 10.2 which is the latest version available and also supports a minimum version of Java 11.
Add checks that may be relevant to the basic and intermediate Java coding standards but are not in checkstyle.xml.

I noticed that Duke also has a checkstyle.xml file in the full-template branch. Can I confirm if that file also needs to be updated?

damithc commented 2 years ago

I noticed that Duke also has a checkstyle.xml file in the full-template branch. Can I confirm if that file also needs to be updated?

@yhtMinceraft1010X Yes.