Closed yhtMinceraft1010X closed 2 years ago
Click here to submit a new iteration when this PR is ready for review.
See this repository's contribution guide for more information.
Merging #128 (512a9b0) into master (865de62) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #128 +/- ##
=========================================
Coverage 72.15% 72.15%
Complexity 399 399
=========================================
Files 70 70
Lines 1232 1232
Branches 125 125
=========================================
Hits 889 889
Misses 311 311
Partials 32 32
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 865de62...512a9b0. Read the comment docs.
I tried running CanIHasReview but kept getting the same error for each attempt. Here is an issue describing the error for one such attempt: https://github.com/CanIHasReview/CanIHasReview/issues/37
I tried running CanIHasReview but kept getting the same error for each attempt. Here is an issue describing the error for one such attempt: CanIHasReview/CanIHasReview#37
@yhtMinceraft1010X while we wait for a response from CanIHasReview maintainer, we can process this PR without CanIHasReview.
@se-edu/tech-team-level1 for your review please ...
@yhtMinceraft1010X submitted v7 for review.
@yhtMinceraft1010X submitted v8 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v7 and v8) (:chart_with_upwards_trend: Range-Diff between v7 and v8)
@yhtMinceraft1010X Are the three commits independent incremental changes? If not, they should be in the same commit.
@yhtMinceraft1010X submitted v9 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v8 and v9) (:chart_with_upwards_trend: Range-Diff between v8 and v9)
Thanks for the PR @yhtMinceraft1010X
Confirmed file
/files
/directory
are called 'flags'?
Can revise the 2nd paragraph of the proposed commit message to remove the reference to RepoSense (as that project is not related to AB3)?
Thanks for the PR @yhtMinceraft1010X Confirmed
file
/files
/directory
are called 'flags'? Can revise the 2nd paragraph of the proposed commit message to remove the reference to RepoSense (as that project is not related to AB3)?
I realised the proper term should be args
. I've made the changes in the proposed commit message.
Fixes #127
Proposed Commit Message: