search

se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 415 forks source link

Change `tagged` variable in Storage component to plural form. #148

Closed Py0000 closed 1 year ago

Py0000 commented 1 year ago

Fixes #147

Change the variable tagged to tags in the affected class (src/main/java/seedu/address/storage/JsonAdaptedPerson.java).

canihasreview[bot] commented 1 year ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

codecov-commenter commented 1 year ago

Codecov Report

Merging #148 (d6ad1e5) into master (77a32bf) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #148   +/-   ##
=========================================
  Coverage     72.15%   72.15%           
  Complexity      399      399           
=========================================
  Files            70       70           
  Lines          1232     1232           
  Branches        125      125           
=========================================
  Hits            889      889           
  Misses          311      311           
  Partials         32       32
Impacted Files Coverage Δ
.../java/seedu/address/storage/JsonAdaptedPerson.java 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

damithc commented 1 year ago

@Py0000 thanks for this PR, and sorry for the delay in processing it. Can you follow the instructions in https://github.com/se-edu/addressbook-level3/pull/148#issuecomment-1288977823 so that the PR is compliant with our process.