search

se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 415 forks source link

Typo in `custom-styles.scss` for site website #149

Closed jasonqiu212 closed 1 year ago

jasonqiu212 commented 1 year ago

In docs/_sass/minima/custom-styles.scss line 13:

  order-radius : $alert-border-radius;

I believe this should be replaced with border-radius?

damithc commented 1 year ago

Thanks for the bug report @jasonqiu212 Have you tried it? Does it make a difference in how the pages are displayed?

jasonqiu212 commented 1 year ago

Hi professor,

Yes, I observed that the border radius of the colored boxes containing tips/caution/note were affected.

Here is a screenshot before the change:

Screen Shot 2022-10-31 at 10 06 17 AM

Here is a screenshot after changing line 13 to border-radius: $alert-border-radius:

Screen Shot 2022-10-31 at 10 06 33 AM
damithc commented 1 year ago

Yes, I observed that the border radius of the colored boxes containing tips/caution/note were affected.

Here is a screenshot before the change: Screen Shot 2022-10-31 at 10 06 17 AM

Here is a screenshot after changing line 13 to border-radius: $alert-border-radius: Screen Shot 2022-10-31 at 10 06 33 AM

@jasonqiu212 Nice find. We'll fix this in due course but it will not help current users. So, feel free to share this with the classmates (e.g., post in the class forum).