Closed Eclipse-Dominator closed 1 year ago
Click here to submit a new iteration when this PR is ready for review.
See this repository's contribution guide for more information.
There is an issue with the exit command where exit will attempt to save all file before exiting and due to the permission error, it will prevent the program from exiting.
I came up with the following solutions regarding the above
I am not sure which solution is the right approach.
A separate issue is when the preference folder is not writeable. Error messages like so can still be seen The IO exception is still caught here
//Update config file in case it was missing to begin with or there are new/unused fields
try {
ConfigUtil.saveConfig(initializedConfig, configFilePathUsed);
} catch (IOException e) {
logger.warning("Failed to save config file : " + StringUtil.getDetails(e));
}
return initializedConfig;
So I am not sure if we should change this message.
Refer to #172
Fixes #73 Continued from #77
Renames warning message to remind user to exit the application immediately.