Closed Eclipse-Dominator closed 1 year ago
Click here to submit a new iteration when this PR is ready for review.
See this repository's contribution guide for more information.
@Eclipse-Dominator submitted v1 for review.
Merging #169 (6defd38) into master (f0c6861) will not change coverage. The diff coverage is
100.00%
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## master #169 +/- ##
=========================================
Coverage 72.15% 72.15%
Complexity 399 399
=========================================
Files 70 70
Lines 1232 1232
Branches 125 125
=========================================
Hits 889 889
Misses 311 311
Partials 32 32
Impacted Files | Coverage Δ | |
---|---|---|
.../java/seedu/address/storage/JsonAdaptedPerson.java | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@Eclipse-Dominator submitted v2 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2) (:chart_with_upwards_trend: Range-Diff between v1 and v2)
I have updated the commit to include a commit body. I did do some testing with changes and no issues were spotted.
@Eclipse-Dominator submitted v3 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3) (:chart_with_upwards_trend: Range-Diff between v2 and v3)
@Eclipse-Dominator submitted v3 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3) (:chart_with_upwards_trend: Range-Diff between v2 and v3)
Yup I just realized it as well.
@Eclipse-Dominator submitted v4 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v3 and v4) (:chart_with_upwards_trend: Range-Diff between v3 and v4)
Thanks to @Py0000 for your contribution to this PR too.
Fixes #147
Change the variable tagged to tags in the affected class [took over from #153] Change the json property tagged to tags in all affected save files (src/main/java/seedu/address/storage/JsonAdaptedPerson.java).