[#173] Null class logger not logging to logger output

[Eclipse-Dominator]

Fixes #173

There is a check when a null class logger is created. However, AB3 currently do not actually use null class loggers.

Let's replace the null class check with assertion instead as per YAGNI principe.

[canihasreview[bot]]

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

[codecov-commenter]

Codecov Report

Merging #174 (c715bfa) into master (b581276) will increase coverage by 0.13%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #174      +/-   ##
============================================
+ Coverage     71.92%   72.06%   +0.13%     
  Complexity      399      399              
============================================
  Files            70       70              
  Lines          1236     1235       -1     
  Branches        127      127              
============================================
+ Hits            889      890       +1     
+ Misses          315      314       -1     
+ Partials         32       31       -1     

Impacted Files	Coverage Δ
...in/java/seedu/address/commons/core/LogsCenter.java	83.33% <100.00%> (+4.95%)	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[canihasreview[bot]]

v1

@Eclipse-Dominator submitted v1 for review.

• [v1 1/1] Add assertion for null class loggers

(:books: Archive)

Checkout this PR version locally

```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/174/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.

[canihasreview[bot]]

v2

@Eclipse-Dominator submitted v2 for review.

• [v2 1/1] Add assertion for null class loggers

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2) (:chart_with_upwards_trend: Range-Diff between v1 and v2)

Checkout this PR version locally

```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/174/2/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.

[Eclipse-Dominator]

I have replaced certain instance of clazz with class in the commit since clazz is a term to replace class in java to avoid using preserved keyword.

[canihasreview[bot]]

v3

@Eclipse-Dominator submitted v3 for review.

• [v3 1/1] Add a null check to LogCenter.getLogger(Class)

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3) (:chart_with_upwards_trend: Range-Diff between v2 and v3)

Checkout this PR version locally

```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/174/3/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.