se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
27 stars 411 forks source link

[#171] Updating gitignore to account for bin folder #175

Closed Eclipse-Dominator closed 1 year ago

Eclipse-Dominator commented 1 year ago

Fixes #171

Previously, running the command ./gradlew generated a bin folder containing all the .class files. To prevent accidentally committing files to the repository, let's adds /bin/ to the .gitignore file

canihasreview[bot] commented 1 year ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

codecov-commenter commented 1 year ago

Codecov Report

Merging #175 (17dc864) into master (1e05fef) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##             master     #175   +/-   ##
=========================================
  Coverage     72.15%   72.15%           
  Complexity      399      399           
=========================================
  Files            70       70           
  Lines          1232     1232           
  Branches        125      125           
=========================================
  Hits            889      889           
  Misses          311      311           
  Partials         32       32           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

canihasreview[bot] commented 1 year ago

v1

@Eclipse-Dominator submitted v1 for review.

(:books: Archive)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/175/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
damithc commented 1 year ago

I could not reproduce this behavior on Windows i.e., I ran gradlew but it did not create a bin folder. 🤔

Commit message: generated -> generates?

Eclipse-Dominator commented 1 year ago

After some investigation, the creation of bin/ folder seems to be caused by a separate vscode extension. As the focus of the module is the use of Intellij, let's close this for now.