Closed Eclipse-Dominator closed 1 year ago
Click here to submit a new iteration when this PR is ready for review.
See this repository's contribution guide for more information.
@Eclipse-Dominator submitted v1 for review.
@Eclipse-Dominator submitted v2 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2) (:chart_with_upwards_trend: Range-Diff between v1 and v2)
Merging #177 (b7a2713) into master (481a3d9) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #177 +/- ##
=========================================
Coverage 72.06% 72.06%
Complexity 399 399
=========================================
Files 70 70
Lines 1235 1235
Branches 127 127
=========================================
Hits 890 890
Misses 314 314
Partials 31 31
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@zhongfu I remember you did some investigation into this problem earlier. If you are free, your inputs are welcome.
@zhongfu thanks very much for checking. :+1:
@Eclipse-Dominator submitted v3 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3) (:chart_with_upwards_trend: Range-Diff between v2 and v3)
Fixes #166
Conflict between JavaFx version 11 and Ubuntu 18.04 and above described in JDK-8210411 presents a compatibility issue for users using Ubuntu 18.04 and above. This fatal crash also causes JVM to generate a hs_err_pid log file.
This issue is fixed in JavaFx version 11.0.2. Let's bump JavaFx to the appropriate version to avoid this issue.