se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 426 forks source link

[#178] Include JVM Crash Logs in gitignore #179

Closed Eclipse-Dominator closed 1 year ago

Eclipse-Dominator commented 1 year ago

Fixes #178

hs_err_pid files are being generated by JVM when a fatal error occurs.

These files should not be pushed to the repository.

Let's add hs_err_pid[0-9]*.log to gitignore.

canihasreview[bot] commented 1 year ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

canihasreview[bot] commented 1 year ago

v1

@Eclipse-Dominator submitted v1 for review.

(:books: Archive)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/179/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
codecov-commenter commented 1 year ago

Codecov Report

Merging #179 (6eb0d19) into master (a3f7c82) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##             master     #179   +/-   ##
=========================================
  Coverage     71.92%   71.92%           
  Complexity      399      399           
=========================================
  Files            70       70           
  Lines          1236     1236           
  Branches        127      127           
=========================================
  Hits            889      889           
  Misses          315      315           
  Partials         32       32           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

damithc commented 1 year ago

Thanks for the PR @Eclipse-Dominator I felt the change is simple enough to warrant a subject-only commit message, so I took the liberty of shortening it.