se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 426 forks source link

[#183] Inconsistency between GitHub file preview and GitHub Page #184

Closed Eclipse-Dominator closed 1 year ago

Eclipse-Dominator commented 1 year ago

Fixes #183

The use of differing markdown renderer in Github pages causes certain tables that can be displayed properly in Github to appear jumbled in Github pages.

To ensure consistent rendering between GitHub markdown and the markdown in Gtihub pages, Let's replace the kramdown markdown renderer with GFM in _config.yml.

canihasreview[bot] commented 1 year ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

codecov[bot] commented 1 year ago

Codecov Report

Merging #184 (679f7fd) into master (481a3d9) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #184   +/-   ##
=========================================
  Coverage     72.06%   72.06%           
  Complexity      399      399           
=========================================
  Files            70       70           
  Lines          1235     1235           
  Branches        127      127           
=========================================
  Hits            890      890           
  Misses          314      314           
  Partials         31       31           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Eclipse-Dominator commented 1 year ago

See compatibility issue