Closed Eclipse-Dominator closed 1 year ago
Click here to submit a new iteration when this PR is ready for review.
See this repository's contribution guide for more information.
Merging #195 (fb1234c) into master (9356ae9) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #195 +/- ##
=========================================
Coverage 73.61% 73.61%
Complexity 420 420
=========================================
Files 71 71
Lines 1285 1285
Branches 126 126
=========================================
Hits 946 946
Misses 307 307
Partials 32 32
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@Eclipse-Dominator submitted v1 for review.
Do I need to create an issue for this PR?
Do I need to create an issue for this PR?
@Eclipse-Dominator Not strictly necessary.
As discussed, let's not do this for now, in the interest of keeping the build.gradle file structure simple. We can reopen this if we decide to go ahead with this in the future. Thanks for the work @Eclipse-Dominator and for inputs @linustws
Currently, dependencies import for JavaFX is as below:
Importing dependencies for JavaFX in build.gradle is highly repetitive. This repetition makes it difficult to read, modify, and edit modules if necessary. Currently, for each JavaFX module, the dependencies for 'win', 'mac' and 'linux' are individually added. To address this issue, it would be more efficient to use a nested for loop to handle these imports.
By implementing a nested for loop, we can reduce code duplication and improve the ease of modifying modules and platforms. Simplifying the import process for JavaFX dependencies will enhance overall code readability and maintainability.
Therefore, let's reduce code duplication by implementing a nested for loop to handle the import of JavaFX dependencies in build.gradle.