se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 426 forks source link

Messages: move to seedu.address.logic package #198

Closed Eclipse-Dominator closed 1 year ago

Eclipse-Dominator commented 1 year ago

Adapted from: commit

The Messages class contains common user-facing messages used by commands and parsers in the logic layer.

However, Messages is contained within the seedu.address.commons.core package, which is too general. Given that the Messages class is user-facing, it would only ever be used by the logic and ui layers, and thus would fit better inside the seedu.address.logic package.

Furthermore, in the next few commits we will be adding methods to the Messages class which require access to model classes. This would not be possible if the Messages class is still in the commons layer, which is the lowest layer of our architecture and can't access component.

As such, let's move the Messages class to the seedu.address.logic package.

canihasreview[bot] commented 1 year ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

codecov[bot] commented 1 year ago

Codecov Report

Merging #198 (8d3049f) into master (9356ae9) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #198   +/-   ##
=========================================
  Coverage     73.61%   73.61%           
  Complexity      420      420           
=========================================
  Files            71       71           
  Lines          1285     1285           
  Branches        126      126           
=========================================
  Hits            946      946           
  Misses          307      307           
  Partials         32       32           
Impacted Files Coverage Δ
src/main/java/seedu/address/logic/Messages.java 91.66% <ø> (ø)
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø)
...va/seedu/address/logic/commands/DeleteCommand.java 100.00% <ø> (ø)
...java/seedu/address/logic/commands/EditCommand.java 97.43% <ø> (ø)
...java/seedu/address/logic/commands/FindCommand.java 100.00% <ø> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <ø> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 100.00% <ø> (ø)
...eedu/address/logic/parser/DeleteCommandParser.java 100.00% <ø> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 92.30% <ø> (ø)
.../seedu/address/logic/parser/FindCommandParser.java 100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

canihasreview[bot] commented 1 year ago

v1

@Eclipse-Dominator submitted v1 for review.

(:books: Archive)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/198/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
damithc commented 1 year ago

Merged with changes to the commit message