search

se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 426 forks source link

Upgrade UML diagrams to the new version of PlantUML #200

Closed damithc closed 1 year ago

damithc commented 1 year ago

Seems the new version has some breaking changes, as the MarkBind team found (some info here) e.g., no need for GraphViz on Windows

Both diagrams and Dev Guide might needs updating.

damithc commented 1 year ago

@Eclipse-Dominator can have a look?

Eclipse-Dominator commented 1 year ago

Do we adapt to the newer lighter-colored theme or should we preserve the old color scheme?

The most noticeable theme change is the border color change as well as the background change

image

For now I will use the old theme version.

damithc commented 1 year ago

@Eclipse-Dominator I think there is no good reason to keep the old style. We can go with the new default style.

Eclipse-Dominator commented 1 year ago

I think it might be better to stick with the old theme / rose theme for now as some of the color scheme changes in style.puml as some of the diagrams are based on the old color scheme.

damithc commented 1 year ago

I think it might be better to stick with the old theme / rose theme for now as some of the color scheme changes in style.puml as some of the diagrams are based on the old color scheme.

I see. I would like to see the difference before making the decision. It is ideal if new batches of student's don't need to follow the legacy stuff at all, as they are unnecessary complications for them.

Eclipse-Dominator commented 1 year ago

I will provide a separate PR to display the changes in color schemes