se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
27 stars 411 forks source link

Update UML diagrams to the new version of PlantUML #201

Closed Eclipse-Dominator closed 11 months ago

Eclipse-Dominator commented 11 months ago

Fixes #200

Alternative ver where the newer theme is used instead: #202

As of PlantUML 1.2023.2, there has been a change in behavior when rendering PlantUML diagrams. This causes some of the PlantUML diagrams to be rendered incorrectly or fail to compile. Some of the diagrams are also being rendered in a different theme due to a change in the default color theme.

Therefore some of the PlantUML code and images need to be updated to ensure functionality as well as consistency. The old color scheme also needs to be applied as some of the manual color changes are based on the older theme.

canihasreview[bot] commented 11 months ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

codecov[bot] commented 11 months ago

Codecov Report

Merging #201 (0ab2649) into master (a976ec9) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #201   +/-   ##
=========================================
  Coverage     74.03%   74.03%           
  Complexity      423      423           
=========================================
  Files            71       71           
  Lines          1290     1290           
  Branches        127      127           
=========================================
  Hits            955      955           
  Misses          301      301           
  Partials         34       34           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

canihasreview[bot] commented 11 months ago

v1

@Eclipse-Dominator submitted v1 for review.

(:books: Archive)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/201/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
damithc commented 11 months ago

Closing in favor of #202