se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
27 stars 411 forks source link

Add lower level logging statement #203

Closed Eclipse-Dominator closed 10 months ago

Eclipse-Dominator commented 11 months ago

Fixes #194

Includes some lower-level logging statements as well as moving some of the existing logging statements to other levels.

canihasreview[bot] commented 11 months ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

codecov[bot] commented 11 months ago

Codecov Report

Merging #203 (7c506ec) into master (08fe6e3) will decrease coverage by 0.01%. The diff coverage is 60.00%.

@@             Coverage Diff              @@
##             master     #203      +/-   ##
============================================
- Coverage     75.26%   75.26%   -0.01%     
  Complexity      419      419              
============================================
  Files            71       71              
  Lines          1334     1338       +4     
  Branches        126      126              
============================================
+ Hits           1004     1007       +3     
- Misses          300      301       +1     
  Partials         30       30              
Files Changed Coverage Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

canihasreview[bot] commented 11 months ago

v1

@Eclipse-Dominator submitted v1 for review.

(:books: Archive)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/203/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
canihasreview[bot] commented 11 months ago

v2

@Eclipse-Dominator submitted v2 for review.

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2) (:chart_with_upwards_trend: Range-Diff between v1 and v2)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/203/2/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
canihasreview[bot] commented 11 months ago

v3

@Eclipse-Dominator submitted v3 for review.

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3) (:chart_with_upwards_trend: Range-Diff between v2 and v3)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/203/3/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
damithc commented 11 months ago

@se-edu/tech-team-level1 for your review ...

damithc commented 11 months ago

@Eclipse-Dominator pls update the PR description to match the current state of the changes done.

damithc commented 11 months ago

@Eclipse-Dominator reminder about this

canihasreview[bot] commented 11 months ago

v4

@Eclipse-Dominator submitted v4 for review.

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v3 and v4) (:chart_with_upwards_trend: Range-Diff between v3 and v4)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/203/4/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
damithc commented 10 months ago

@Eclipse-Dominator shall we wrap this up soon?

damithc commented 10 months ago

Added these commits to master with minor tweaks.