se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
27 stars 411 forks source link

[Revised] Adding MarkBind as an alternative docs option #206

Closed damithc closed 10 months ago

damithc commented 10 months ago

A revised version based on #156 Once finalized, all commits will be squashed to one commit and the commit message will mention #156 as the primary source of changes Deployed site https://damithc.github.io/ab3-markbind/index.html

canihasreview[bot] commented 10 months ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

codecov[bot] commented 10 months ago

Codecov Report

Merging #206 (da647a3) into master (517b785) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #206   +/-   ##
=========================================
  Coverage     75.26%   75.26%           
  Complexity      419      419           
=========================================
  Files            71       71           
  Lines          1338     1338           
  Branches        126      126           
=========================================
  Hits           1007     1007           
  Misses          301      301           
  Partials         30       30           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

damithc commented 10 months ago

@tlylt can have a look?

tlylt commented 10 months ago

@tlylt can have a look?

Other than the above, LGTM!

damithc commented 10 months ago

Released to students as an option (see step 4 here) Closing this PR as it is never meant to be merged. We can observe how things go this semester and revise further in the following semester.

Thanks again @tlylt for your immense help with this. 💯