se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 426 forks source link

[#214] Fix alignment by changing index font #215

Closed baskargopinath closed 3 months ago

baskargopinath commented 3 months ago

Fixes #214

Explanation below image

image

canihasreview[bot] commented 3 months ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

canihasreview[bot] commented 3 months ago

v1

@baskargopinath submitted v1 for review.

(:books: Archive)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/215/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
canihasreview[bot] commented 3 months ago

v2

@baskargopinath submitted v2 for review.

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2) (:chart_with_upwards_trend: Range-Diff between v1 and v2)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/215/2/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
damithc commented 3 months ago

@baskargopinath If the second commit is simply fixing an error introduced by the first commit, the proper fix is to revise the first commit to not introduce the error at all. That way, we avoid polluting the history with unnecessary commits.

baskargopinath commented 3 months ago

Understood prof will fix it asap @damithc

canihasreview[bot] commented 3 months ago

v3

@baskargopinath submitted v3 for review.

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3) (:chart_with_upwards_trend: Range-Diff between v2 and v3)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/215/3/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
damithc commented 3 months ago

@baskargopinath two other comments:

  1. It's good enough for the commit message subject to state the WHAT part (no need for the HOW) e.g., Fix misalignment of person names. The HOW part can be in the body.
  2. The max commit message body width is 72 chars. Looks like yours is unnecessarily narrower than that.
baskargopinath commented 3 months ago

@damithc okay ived fixed it prof. I had to delete this repo so i can fork AB3-J17 for 2103R. I have sent the PR from my nus github account instead with the requested changes