Closed baskargopinath closed 3 months ago
Click here to submit a new iteration when this PR is ready for review.
See this repository's contribution guide for more information.
@baskargopinath submitted v1 for review.
@baskargopinath submitted v2 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2) (:chart_with_upwards_trend: Range-Diff between v1 and v2)
@baskargopinath If the second commit is simply fixing an error introduced by the first commit, the proper fix is to revise the first commit to not introduce the error at all. That way, we avoid polluting the history with unnecessary commits.
Understood prof will fix it asap @damithc
@baskargopinath submitted v3 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3) (:chart_with_upwards_trend: Range-Diff between v2 and v3)
@baskargopinath two other comments:
Fix misalignment of person names
. The HOW part can be in the body.@damithc okay ived fixed it prof. I had to delete this repo so i can fork AB3-J17 for 2103R. I have sent the PR from my nus github account instead with the requested changes
Fixes #214
Explanation below image
cell_big_index
style to use Arial Mono.HBox
andLabel
elements for consistent alignment.